Collecting physical media is very valuable if you are a passionate gamer. Time has proven that the older a game gets, the harder it will be to legally obtain it. Yes, emulation is a thing but doesn't quite beat the experience on the original hardware IMO. And of course emulation is under constant legal scrutiny to the point where it's only a matter of time before enough money passes hands and emulation itself could be outlawed or heavily restricted.

Unless you have extraordinarily rare games, likely you will not see any financial benefit. If you do not want to play any of your games ever again, and you will never have kids or anyone you want to pass history onto, then likely the collection holds no value.