1079

submitted 1 year ago by EarJava@lemmy.fmhy.ml to c/programmer_humor@programming.dev

57 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] fusio@lemmy.world 36 points 1 year ago

That's why PR should be small. It's much better to have multiple PRs than a single big one.

Totally fair to have gigantic PR full of boilerplate code, but generally you can split the boilerplate and your feature in 2 PRs, where only the feature will get a proper review.

All of this obviously depends on the criticality of the system :p

[-] Rikudou_Sage@lemmy.world 10 points 1 year ago

Or split them per commit at the minimum if you don't want to create a separate PR.

[-] Asifall@lemmy.world 2 points 1 year ago

That can lead to another problem though, which is that if a developer knows a merge is only part of the whole change, it becomes easy to assume any issues will be handled elsewhere.