4
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 14 Jan 2024
4 points (100.0% liked)
/kbin meta
38 readers
1 users here now
Magazine dedicated to discussions about the kbin itself. Provide feedback, ask questions, suggest improvements, and engage in conversations related to the platform organization, policies, features, and community dynamics. ---- * Roadmap 2023 * m/kbinDevlog * m/kbinDesign
founded 1 year ago
@Pamasich
I have resolved the aforementioned issues with a hotfix on the testing branch; please test when time permits. Executive summary:
more
s are being removed now for comments with overflow text. What I thought would be a quick fix turned into hours, and I thought I was losing my marbles over this one for a long time, since the tree clearly showed numerous duplicatemore
s, but only one per comment was being shown at runtime of the script. At first, I did not seriously think that the mod was completing its runtime cycle prior to the duplicate mores being spawned, but indeed this is what was happening. For now, I have added a 20ms sleep before clearing the extramore
s, and this seems to suffice to let them propagate before the mod can continue with the cleanup phase. This seems satisfactory for now, short of attaching observers to wait for the duplicatemore
s to appear.I believe that covers everything. It should be possible to switch the mod on and off at will now and see no adverse effect.
Teardown isn't working for me, tried multiple devices and turned my custom styling off.
After teardown this is how the site looks like to me. Also, it seems you need to remove the mores on teardown too. The more issue is now fixed when the mod is active, but appears again after teardown.
You're right, looks like I missed something that was obscured by custom styling.
And good catch on the mores appearing on teardown. This mod is turning out to be quite a beast. Thanks for testing.
I had just forgotten something simple (unload the threaded comments CSS):
Before:
After:
This is live on testing, but might take a sec to propagate due to GitHub's caching feature.
This works for me now.