588
Whatever 'Clean Code' you write now, it'll be shit eventually and in need of a complete rewrite (programming.dev)
submitted 2 months ago by RonSijm@programming.dev to c/programmer_humor@programming.dev
89 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[-] JackbyDev@programming.dev 12 points 2 months ago

Which of these do you prefer?

A?

@Test
  public void turnOnLoTempAlarmAtThreshold() throws Exception {
    wayTooCold();
    assertEquals(“HBchL”, hw.getState());
  }

Or B?

@Test
  public void turnOnLoTempAlarmAtThreashold() throws Exception {
    hw.setTemp(WAY_TOO_COLD);
    controller.tic();
    assertTrue(hw.heaterState());
    assertTrue(hw.blowerState());
    assertFalse(hw.coolerState());
    assertFalse(hw.hiTempAlarm());
    assertTrue(hw.loTempAlarm());
  }

Uncle Bob's Clean Code suggestsOption A

[-] magic_lobster_party@kbin.run 11 points 2 months ago

I almost pulled my hair out when I read that section. One is super obvious without any prior experience with the code. The other is an obscure abomination only he can understand. He’s obviously super proud of his abomination and thinks it’s a prime example of “clean code”.

[-] JackbyDev@programming.dev 8 points 2 months ago

It's also a good example of how being too dogmatic about function length can hide important details.

[-] Threeme2189@sh.itjust.works 8 points 2 months ago

Why in the holy mother of rust is A the better option?

[-] magic_lobster_party@kbin.run 5 points 2 months ago

His idea is that it’s faster to read that short string once you learn how to read it. But then you need to learn how to read it.

In my experience, every time I thought of something clever like this, I’ll almost always regret it a month later when I revisit the code.

[-] JackbyDev@programming.dev 4 points 2 months ago

Ask "Clean" Coders I guess lmao. Beats me.

[-] RonSijm@programming.dev -1 points 2 months ago

I've started to prefer option A to be honest.

In C# I'm using Verify - So I prefer to just use Verify(state); and compare the entire state against a json saved state, instead of manually verifying every individual property

this post was submitted on 10 Aug 2024
588 points (97.3% liked)

Programmer Humor

19454 readers
770 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev