221

Why do comment counts often disagree with what I see? (lemmy.world)

submitted 1 year ago by br3d@lemmy.world to c/fediverse@lemmy.world

48 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] athlon@lemm.ee 18 points 1 year ago

I accidentally made a post that has -3 comments.

This happens because Lemmy does not count the actual number of comments that there are under the post, but instead there is a counter per post. This is not necessarily a bad thing, but it does not seem like the counter is every synced with the actual count of comments.

[-] Mr_Buscemi@lemmy.blahaj.zone 4 points 1 year ago

I think I noticed that if a commenter deleted their comment then the total comments would go down by 1. On a post with only one comment that also got deleted, it made it show as -1 comments.

[-] PeleSpirit@lemmy.world 2 points 1 year ago

What does counter per post mean?

Also, I always thought that was because they have to "call home" to get updated and there's time in between.

[-] athlon@lemm.ee 4 points 1 year ago

Ok, so basically, there is multiple ways one could comment count. The most obvious option is to count the actual number of comments under the post. This might be in practice slow, as you must load all comments under the post. An alternative approach is to have a count variable for post, which is increased or decreased by 1 if post is added/removed. It's way faster to retrieve that variable, instead of getting all comments and counting the number of them. The problem starts if some anomaly happens that is not accounted for, so for example, if I request the same comment to be deleted multiple times. So that counter can be decreased more than once for the same comment. This could be fixed pretty easily:

if comment_to_delete is deleted {
	// Do not do anything
	return
}

post.comment_count -= 1
delete_comment(comment_to_delete)

And yeah, I thought so too, but ever since I stumbled upon this bug, I think the way the comment count is stored is through the counter variable.

[-] PeleSpirit@lemmy.world 2 points 1 year ago

I'm sorry, I'm not really understanding since I'm not techy. Are you saying it counts how many are added or removed, not the total amount? I don't understand the difference or why that would be easier to pull info from.

[-] density@kbin.social 5 points 1 year ago

because when you load any page listing posts, you don't want your server to have to go and download the actual entire comment thread for every post that is listed. And then have to go and count how many there are.

Because it would be slow, especially with multiple servers involved. Every time you loaded your home page or a community the server would have to start from scratch gathering the data. It would be more accurate but it would be very hard. And not give a lot of extra value.

So it's more efficient to have a piece of data attached to the post that just reports the number of comments. Same way as there is a piece of data that contains the title, the name of the person who posted it etc. And that value is updated in some way. Apparently in a way that has not yet been perfected. :)

[-] PeleSpirit@lemmy.world 5 points 1 year ago

I appreciate your patience, I updated my previous comment, I think I finally get what you're saying.

[-] athlon@lemm.ee 4 points 1 year ago

Getting the total number of all comments may be very resource heavy if there is a lot of comments.

If it's just 5 comments, then the computer can quickly get them all from database and count how many of them are there. Now imagine if there is 50 000 comments and suddenly, you me and entire website ask "how many comments are there for this post?"

Suddenly the computer is overwhelmed by the request and you may end up crashing it due to amount of tasks it has to do.

It's way faster if instead of all of that, the computer kept track of a number of all comments and simply adjust it when comment is added or removed. It does not have to get all the comments and count how many are there, just simply return the number and you are done.

But in the essence, you sacriface potential accuracy for speed. You may accidentally "desynchronize" the counter - if an user requests a removal of the same comment twice, and you don't check if that comment was not removed. Or, in theory, if two separate users add or remove a comment at the same time. This is called "race condition", which is common in multi-threaded computing.

[-] PeleSpirit@lemmy.world 1 points 1 year ago

Okay, is it because I haven't had my coffee yet?

First line:

Getting the total number of all comments may be very resource heavy if there is a lot of comments.

Fourth paragraph:

It’s way faster if instead of all of that, the computer kept track of a number of all comments and simply adjust it when comment is added or removed. It does not have to get all the comments and count how many are there, just simply return the number and you are done.

What is the difference between the bolded parts?

[-] athlon@lemm.ee 3 points 1 year ago

First method does not store the number itself anywhere. Let's assume that you store apples. I come and ask you "How many apples do you have?". To answer, you go and count every single apple one by one and return me the number. It's very easy if you have a small number of apples, but if you have, let's say, 5000 apples - you can see how long it may take.

Second option is you keeping a track of how many apples you have in stock by having it written down somewhere. If I ask you "How many apples do you have?" you just pull out your notepad and tell me the number. If you give me an apple, you just adjust the number you have written down already.

[-] PeleSpirit@lemmy.world 1 points 1 year ago* (last edited 1 year ago)

Okay, I swear I almost have it. Where does the stock number come from? Does it regularly pull a number instead of counting, is that the difference? I think what you're saying is, instead of it checking live, it has a total number taken every so often. Yes?

Edit: Okay I get it, except for where my initial count comes from. I guess it starts at 0?

First way, constantly checking the number of comments and just goes off of that.
Second way, stores the number 0 at first and then only updates when a comment is added or removed.

Am I ready for my certificate yet? Yikes. Thanks for going slow, lol.