Community to discuss Summit, an open-source Lemmy reader for Android.
App (Play Store): https://play.google.com/store/apps/details?id=com.idunnololz.summit
APK: https://github.com/idunnololz/summit-for-lemmy/releases
Source: https://github.com/idunnololz/summit
Support the app
Website: https://summit.idunnololz.com/
Usually when I reach the end of the feed, it just loads more. But recently, I started getting a bad request error instead. Not every time I reach the end, but once I get it it doesn't go away when I tap on retry.
Is anyone else seeing this happening? Is there anything I can do to fix it?
This is a DB attack vector, which is why lemmy long ago switched to cursor pagination.
You need to open up an issue in the summit repo asking the dev to switch away from the deprecated page/limit, and to cursor pagination.
I disagree with this, and already opened a PR to increase the limit to 100. This way users wont run into problems, and it prevents DDoS just as well.
Sorry for the late update, just got back from break. I think I posted this somewhere else but I'll re-iterate here as well. Basically this is a limitation on the server side when page indices are used instead of cursors. I specifically chose to implement Summit using page indicies instead of cursors because (1) page indices are more feature rich and (2) it results in cleaner and more maintainable code on the client. Cursors has several limitations such as the inability to go to the previous page. Lemmy is also very inconsistent as many endpoints only support page indicies and not cursors. This means that if I were to support cursors I would have to write two different pagination implementations.
That being said, due to the issue of servers now limiting the max page index to a low number like 10, I will likely be forced to implement cursors on the client. I'll work to implement this for the next release since this is a pretty big issue.
Sorry it's such a complicated issue. You're an absolute hero for looking into it though!
I'm seeing this too, @flamingos@feddit.uk reckon it's anything on our end?
I can recreate this, the error I'm seeing on the server side is Page limit is > 10. I wish client side gave a better error message here than counldnt_get_posts.
This seems to have been a deliberately changed in this PR to fix comment list sorting DDOS exploit. How this affects clients depends on if they use page or page_cursor, which has no limit.
For now I'll just patch our Lemmy to increase to increase the limit to something more reasonable, like 100. Probably need to upstream this as well as it'll affect every instance on 0.19.14.
Thanks both @smeg@feddit.uk and @flamingos@feddit.uk! I assumed it was an issue with summit so posted here, didn't realise it was an issue with the instance
Likely is. I'm experiencing something similar with timeouts instead, but it happens across clients (and less often since a server upgrade). So probably a change in configuration for your instance, or an uptick in usage/growing userbase?
Either way I'd check to see if this happens on other clients too, first.
I have been getting 400 bad request error in comments, in URL preview of opened posts. I guess something is on summits end. Because, these errors are less frequent in Voyager and its very quick I operation.
Yeah this has been occurring for me as well. It's getting frustrating. Would hate to switch to another lemmy app as otherwise I really enjoy summit.
@idunnololz@lemmy.world just making you aware of this
This might have to do with the user agent issue. I'm planning to do a release tomorrow to fix this.
I've been getting the same for maybe 2/3 weeks now. Quite frustrating because I'm missing a lot of posts and keep getting repeat posts all the time. Plus, sometimes the app just refuses to download images to my phone.
I would hate to leave summit over this, but it's really making Lemmy unusable.
